diff --git a/game-server/app/servers/battle/handler/normalBattleHandler.ts b/game-server/app/servers/battle/handler/normalBattleHandler.ts
index ec88b3f96..e8b330dca 100644
--- a/game-server/app/servers/battle/handler/normalBattleHandler.ts
+++ b/game-server/app/servers/battle/handler/normalBattleHandler.ts
@@ -228,16 +228,20 @@ export class NormalBattleHandler {
             }
             dungeonNum = Object.assign(dungeonNum, checkResult.data)
         } else if (warInfo.warType == WAR_TYPE.NORMAL) {
-            let role = await RoleModel.updateMainWarId(roleId, battleId, nowSeconds());
-            if (role && isSuccess) {
-                let r = new Rank(REDIS_KEY.MAIN_RANK, { serverId });
-                await r.setRankWithRoleInfo(roleId, role.mainWarId, role.mainUpdatedAt, role);
+            if(isSuccess) {
+                let role = await RoleModel.updateMainWarId(roleId, battleId, nowSeconds());
+                if (role) {
+                    let r = new Rank(REDIS_KEY.MAIN_RANK, { serverId });
+                    await r.setRankWithRoleInfo(roleId, role.mainWarId, role.mainUpdatedAt, role);
+                }
             }
         } else if (warInfo.warType == WAR_TYPE.MAIN_ELITE) {
-            let role = await RoleModel.updateMainEliteWarId(roleId, battleId, nowSeconds());
-            if (role && isSuccess) {
-                let r = new Rank(REDIS_KEY.MAIN_ELITE_RANK, { serverId });
-                await r.setRankWithRoleInfo(roleId, role.mainEliteWarId, role.mainEliteUpdatedAt, role);
+            if(isSuccess) {
+                let role = await RoleModel.updateMainEliteWarId(roleId, battleId, nowSeconds());
+                if (role) {
+                    let r = new Rank(REDIS_KEY.MAIN_ELITE_RANK, { serverId });
+                    await r.setRankWithRoleInfo(roleId, role.mainEliteWarId, role.mainEliteUpdatedAt, role);
+                }
             }
         } else if (warInfo.warType == WAR_TYPE.ACT_SELF_SHOP) {
             //糜家商队挑战成功后记录挑战次数