diff --git a/gm-server/app/service/Activity.ts b/gm-server/app/service/Activity.ts index a7ef70345..8e2c8de5a 100644 --- a/gm-server/app/service/Activity.ts +++ b/gm-server/app/service/Activity.ts @@ -203,7 +203,7 @@ export default class Activity extends Service { // let checkTimeResult = await checkActivityEditable(activities); // if(!checkTimeResult) return resResult(STATUS.GM_CAN_NOT_EDIT_ACT); if(data.groupId) { - let checkGroup = await this.checkActivityGroupTypeWithId(data.groupId, activities); + let checkGroup = await this.checkActivityGroupTypeWithId(data.groupId, data.type); if(!checkGroup) return ctx.service.utils.resResult(STATUS.GM_ACTIVITY_NOT_FIT_GROUP_TYPE); } @@ -249,12 +249,15 @@ export default class Activity extends Service { return ctx.service.utils.resResult(STATUS.SUCCESS); } - private async checkActivityGroupTypeWithId(groupId: number, activities: ActivityModelType[]) { + private async checkActivityGroupTypeWithId(groupId: number, activityType: number) { let activityGroup = await ActivityGroupModel.findGroupData(groupId); if(!activityGroup) return false; if(activityGroup.type != 0) { - return await this.checkActivityGroupType(activityGroup.type, activities); + let activityGroupType = await ActivityGroupTypeModel.findByGroupType(activityGroup.type); + let dic = activityGroupType.activityTypes; + let index = dic.findIndex(cur => cur.activityType == activityType); + return index != -1; } return true diff --git a/shared/domain/gvgField/returnData.ts b/shared/domain/gvgField/returnData.ts index 0946583d4..6ed7b7337 100644 --- a/shared/domain/gvgField/returnData.ts +++ b/shared/domain/gvgField/returnData.ts @@ -14,7 +14,7 @@ import { RoleRankInfo } from "../rank"; import { GVGCityType } from "../../db/GVGCity"; import { GVGTeamMem } from "../battleField/gvgBattle"; import { GVGTeamType } from "../../db/GVGTeam"; -import GVGRoleData, { GVGRoleDataType } from "../../db/GVGRoleData"; +import { GVGRoleDataType } from "../../db/GVGRoleData"; class LeagueLeaderInfo { name: string; // 盟主名